For your consideration @kiukchung @d4l3k
Looks like we might need the same for other APIs

setup_pyre.sh lacked +x so I added it here, don't think it justifies a full PR

when the job is not found describe API should return None no?

Do you mean State: None? What would you like it to show @kiukchung ? I'm happy to update my fix as long as it's not an exception.

Do you mean State: None? What would you like it to show @kiukchung ? I'm happy to update my fix as long as it's not an exception.

I mean that if volcano raises an exception when the job does not exist, then torchx's describe() API should return None as per its documentation: https://meta-pytorch.org/torchx/latest/runner.html

describe(app_handle: str)) → Optional[AppDef]
  """
   Reconstructs the application (to the best extent) given the app handle. Note that the reconstructed application may not be the complete app as it was submitted via the run API. How much of the app can be reconstructed is scheduler dependent.

    Returns:

        AppDef or None if the app does not exist anymore or if the scheduler does not support describing the app handle
  """

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.57%. Comparing base (5053c87) to head (1c6204e).

@@           Coverage Diff           @@
##             main    #1151   +/-   ##
=======================================
  Coverage   91.56%   91.57%           
=======================================
  Files          83       83           
  Lines        6593     6599    +6     
=======================================
+ Hits         6037     6043    +6     
  Misses        556      556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Oh, that's a good point, @kiukchung

Let me update this PR then!

This looks perfect, @kiukchung!
torchx status kubernetes://torchx/real-namespace:bla
produces

torchx 2025-10-23 16:39:56 ERROR    AppDef: real-namespace:bla, does not exist or has been removed from kubernetes's data plane

This looks perfect, @kiukchung! torchx status kubernetes://torchx/real-namespace:bla produces

torchx 2025-10-23 16:39:56 ERROR    AppDef: real-namespace:bla, does not exist or has been removed from kubernetes's data plane

cool! nit: can we log the caught exception for debugging purposes?

try:
  ...
except Exception as e:
   # is there a narrower exception we can catch? or make sure this is actually a "app not found"
   if not is_app_not_found_error(e):
     logger.exception("error when querying kubernetes/volcano for the job's status")
   return None

or better just let other errors throw

try:
  ...
except Exception as e:
   if is_app_not_found_error(e):
     return None
   raise # for any other exceptione, re-raise

Done, @kiukchung

I agree it's cleaner

@clumsy can you rebase on top of main?

Done, @kiukchung !